Fix: SafeTarExtractor path containment check can be bypassed due to naive string prefix matching - #1662
Merged
Conversation
…aive string prefix matching
|
@Kirtan-pc is attempting to deploy a commit to the Anuj's projects Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
|
🎉 Thank you for your contribution! Your Pull Request has been merged successfully. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Summary
Replace
os.path.commonpath()withPath.relative_to()inSafeTarExtractor._validate_member()to fix a path containment bypass. Thecommonpathapproach (likestr.startswith()) can be defeated by prefix collisions — e.g., extracting to/tmp/awith a member../ab/evil.txtresolves to/tmp/ab/evil.txt, andcommonpathreturns/tmp/awhich matches, allowing the traversal.Changes
security/tar_safe.py_validate_member(): Replaced theos.path.commonpath()containment check withPath.relative_to(). The new approach raisesValueErrorif the resolved target path is not a true subpath of the extract path, correctly catching prefix-based bypasses (e.g.,/tmp/avs/tmp/ab). The oldcommonpath-based fallback for unresolvable paths was also removed sincerelative_tohandles all cases cleanly.tests/test_security.pytest_prefix_bypass_path_traversal: New test that verifies a tar member targeting a sibling directory with a shared prefix (e.g.,/tmp/avs/tmp/ab) is correctly blocked — a case the oldcommonpath-based check would miss.</|DSML|parameter>
</|DSML|invoke>
</|DSML|tool_calls>
🔗 Linked Issue
Closes #1543
📋 Contribution Checklist